fix(java/driver/flight-sql): include connectionOptions for preparedStatement.close()#4513
Merged
lidavidm merged 5 commits intoJul 19, 2026
Conversation
lidavidm
reviewed
Jul 14, 2026
lidavidm
left a comment
lidavidm
left a comment
Member
There was a problem hiding this comment.
Seems reasonable. Is it possible to test this?
Member
|
Additionally it doesn't seem to compile. |
Contributor
Author
|
@lidavidm Sorry about that. The remainder of the commits failed to push for some reason. Looks like its good now. Edit: Also added testing. |
lidavidm
approved these changes
Jul 19, 2026
Member
|
Thank you! |
unikdahal
added a commit
to unikdahal/arrow-adbc
that referenced
this pull request
Jul 19, 2026
…comments Pass callOptions to closeSession so token-authenticated servers can close their session (per Kyperr's comment; apache#4513 already applies the same fix to prepareStatement.close()). Convert non-finite doubles to their String form inside the TO_JAVA visitor instead of special-casing NaN/Infinity after the fact, matching lidavidm's preference. Use the AdbcException.internal/withCause helpers instead of the raw constructor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016fTAXano7itF4zqBzCXMuC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution for #4512
Include connection options when calling preparedStatement.close()